fix(core):patch apparmor annotations for cronjobs and updating rbac rules #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prateeknandle
force-pushed
the
job-rbac-1
branch
2 times, most recently
from
eaa5f0e to
a82757c
Compare
Prateeknandle
changed the title
Prateeknandle
force-pushed
the
job-rbac-1
branch
2 times, most recently
from
c55c424 to
1bca761
Compare
DelusionalOptimist
force-pushed
the
job-rbac-1
branch
from
1bca761 to
690820b
Compare
Signed-off-by: Prateek Nandle <prateeknandle@gmail.com>
Signed-off-by: Prateek Nandle <prateeknandle@gmail.com>
DelusionalOptimist
force-pushed
the
job-rbac-1
branch
from
690820b to
0a8837f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
patching apparmor annotations for cronjobs. Also, updating RBAC rules for the same.
Connected to #1762 & #1748
Fixes #
Does this PR introduce a breaking change?
no
If the changes in this PR are manually verified, list down the scenarios covered::
yes
Additional information for reviewer? :
The first pod will not be updated with apparmor annoataions, but the subsequent pods will be updated with apparmor annotations.
If we need the same behaviour for cronjob as of job then we need to follow the same approach as we did for job.
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>