-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug #1787 non-k8s: KubeArmor panics when not-enabled policy type is received #1789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @itsCheithanya!
Minor changes to address... Looking good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the changes.
Please see the comments inline @itsCheithanya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @itsCheithanya! 🚀
Please rebase with main so that we can merge.
Can you also do the changes required for handling this new error code in kubearmor-client?
Signed-off-by: Cheithanya <cheithanya2002@gmail.com>
Sure will do that :) |
This fixes the bug that KubeArmor panics when not-enabled policy type is being received
Reproduce the issue :
Modify make run target in KubeArmor's Makefile to something like below such that host policy is disabled:
Once KubeArmor is running, send the below host policy by running
karmor vm policy --gRPC=:32767 add <path-to-policy>
:You'll see that KubeArmor doesn't panic :
Fixes #1787
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>