-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): quote configmap values #1795
Conversation
api documentation verifies the field in the data section is map[string]string |
Hey @daemon1024 can u please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
@tesla59 thanks for reporting the issue and also handling it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@tesla59 can you rebase the branch as we have fixed the CI recently |
Signed-off-by: tesla59 <nishant@heim.id>
be0ce85
to
4015420
Compare
@Aryan-sharma11 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tesla59
Purpose of PR?:
Fixes #1794
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Tested using
helm upgrade --install kubearmor ./deployments/helm/KubeArmor -n kubearmor --create-namespace
Additional information for reviewer? :
No
Checklist:
<type>(<scope>): <subject>