Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): quote configmap values #1795

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented Jul 3, 2024

Purpose of PR?:

Fixes #1794

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
Tested using helm upgrade --install kubearmor ./deployments/helm/KubeArmor -n kubearmor --create-namespace

Additional information for reviewer? :
No

Checklist:

  • Bug fix. Fixes ConfigMap in KubeArmor helm chart is not properly quoted #1794
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@tesla59 tesla59 marked this pull request as ready for review July 3, 2024 07:46
@tesla59
Copy link
Contributor Author

tesla59 commented Jul 3, 2024

api documentation verifies the field in the data section is map[string]string
https://kubernetes.io/docs/reference/kubernetes-api/config-and-storage-resources/config-map-v1/

@tesla59
Copy link
Contributor Author

tesla59 commented Jul 5, 2024

Hey @daemon1024 can u please review this

Copy link
Collaborator

@Prateeknandle Prateeknandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@tesla59 thanks for reporting the issue and also handling it.

Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Aryan-sharma11
Copy link
Member

@tesla59 can you rebase the branch as we have fixed the CI recently

Signed-off-by: tesla59 <nishant@heim.id>
@tesla59 tesla59 force-pushed the tesla/helm-value-fix branch from be0ce85 to 4015420 Compare July 10, 2024 08:14
@tesla59
Copy link
Contributor Author

tesla59 commented Jul 10, 2024

@Aryan-sharma11 done

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tesla59

@kranurag7 kranurag7 merged commit 600adc1 into kubearmor:main Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigMap in KubeArmor helm chart is not properly quoted
5 participants