Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core):timeout when host & cluster security policies crds are not found #1803

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Prateeknandle
Copy link
Collaborator

@Prateeknandle Prateeknandle commented Jul 11, 2024

Purpose of PR?:
in case host & cluster security policies crds are not found, we should timeout rather then infinitely looking for them and ultimately destroying kubearmor daemon.

Fixes #

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

…found

Signed-off-by: Prateek <prateeknandle@gmail.com>
@daemon1024 daemon1024 merged commit 0d103cf into kubearmor:main Jul 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants