feat: mount procfs instead of using hostpid (#1688) #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Patel <yp969803@gmail.com>
|
@daemon1024 can you review the pr |
7 tasks
|
@daemon1024 getting but i have mounted the /proc directory in the kubearmor pod |
|
Getting the same thing while using HostPID |
daemon1024
reviewed
Aug 22, 2024
Comment on lines
+286
to
+290
| { | ||
| Name: "procfs-path", //BPF (read-only) | ||
| MountPath: "/proc", | ||
| ReadOnly: true, | ||
| }, |
There was a problem hiding this comment.
We will need to mount it in a custom directory, maybe /host/proc and configure KubeArmor to consider the custom procfs path wherever it's using it.
There was a problem hiding this comment.
@daemon1024 so i have to check if the env is k8s and if true i have to change "/proc" to "/host/proc" whereever the proc directory is used in the Kuberarmor
|
Closing in favor of #1831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yash Patel yp969803@gmail.com
Purpose of PR?:
Fixes #1688
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>