fix(policyMatcher): handling relative path resource by joining it with cwd #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prateeknandle
requested review from
daemon1024,
DelusionalOptimist and
Aryan-sharma11
daemon1024
reviewed
Sep 4, 2024
daemon1024
reviewed
Sep 4, 2024
Prateeknandle
force-pushed
the
relative_path
branch
from
2ac7561 to
661bef2
Compare
daemon1024
previously approved these changes
Sep 4, 2024
Prateeknandle
force-pushed
the
relative_path
branch
2 times, most recently
from
e58e680 to
837cc68
Compare
|
now passing the generated full path to |
…h cwd Signed-off-by: Prateek <prateeknandle@gmail.com>
Signed-off-by: Prateek <prateeknandle@gmail.com>
Aryan-sharma11
force-pushed
the
relative_path
branch
from
07c1e0c to
817fe92
Compare
daemon1024
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #750
Does this PR introduce a breaking change?
no
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>