fix(build): inject Build Info into systemd package #1928
Conversation
|
@Atharva-Kanherkar thanks for the PR, can you please sign-off, and squash the commits. |
rksharma95
requested review from
Aryan-sharma11,
DelusionalOptimist and
rksharma95
sure! |
Signed-off-by: Atharva-Kanerkar <atharvakanherkar25@gmail.com>
Signed-off-by: Atharva-Kanerkar <atharvakanherkar25@gmail.com>
Signed-off-by: Atharva-Kanerkar <atharvakanherkar25@gmail.com>
Signed-off-by: Atharva-Kanerkar <atharvakanherkar25@gmail.com>
Atharva-Kanherkar
force-pushed
the
lfdflags
branch
from
7e7ed2b to
22e67a3
Compare
|
Hello, @DelusionalOptimist Kindly please review the PR :) |
|
Hey @Atharva-Kanherkar |
| @@ -10,6 +10,10 @@ builds: | |||
| - arm64 | |||
| env: | |||
| - CGO_ENABLED=0 | |||
| ldflags: | |||
| - "-X main.BuildDate={{.Date}} -X main.GitCommit={{.Commit}} -X main.GitBranch={{.Branch}} -X main.GitSummary={{.Summary}}" | |||
There was a problem hiding this comment.
u can add the flags in different lines instead of writing all flags in single line
I have squashed them! |
|
@Atharva-Kanherkar Thanks for the PR. Kindly address the review comments by @tesla59 and also squash your commits. |
Okay! I am sorry but there was some problem which I could not solve so I will just open a new PR. Sorry for the inconvenience. |
fix(build): inject Build Info into systemd package #1928
Purpose of PR?:
This PR ensures that Build Info is included in the KubeArmor systemd package, which was previously missing.
Fixes #1921
Does this PR introduce a breaking change?
No
Additional information for reviewer? :
No
Checklist: