Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extra paragraph and screenshot to further validate DCGM exporter #1159

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

thomasvn
Copy link
Member

@thomasvn thomasvn commented Dec 10, 2024

Related Issue

Proposed Changes

Specifically calls out the DCGM_FI_PROF_GR_ENGINE_ACTIVE metric.

…ter. Specifically calls out the DCGM_FI_PROF_GR_ENGINE_ACTIVE metric.
@thomasvn thomasvn requested a review from a team as a code owner December 10, 2024 21:00
mmurph3
mmurph3 previously approved these changes Dec 10, 2024
Copy link
Contributor

@mmurph3 mmurph3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasvn I think this is helpful and informative. Especially the prom query. This helped us with BAH.

Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor suggestion.

install-and-configure/advanced-configuration/gpu.md Outdated Show resolved Hide resolved
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
@thomasvn
Copy link
Member Author

Link checker seems to be flakey for https://cloud.google.com links right now. I will try to re-run it tomorrow.

 ## Summary

| Status        | Count |
|---------------|-------|
| 🔍 Total      | 1350  |
| ✅ Successful | 1297  |
| ⏳ Timeouts   | 0     |
| 🔀 Redirected | 0     |
| 👻 Excluded   | 47    |
| ❓ Unknown    | 0     |
| 🚫 Errors     | 3     |

## Errors per input

### Errors in install-and-configure/install/cloud-integration/gcp-out-of-cluster/README.md

* [500] [https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#detailed-usage-cost-data-schema](https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#detailed-usage-cost-data-schema) | Failed: Network error: Internal Server Error

### Errors in install-and-configure/advanced-configuration/gpu.md

* [500] [https://cloud.google.com/kubernetes-engine/docs/how-to/dcgm-metrics](https://cloud.google.com/kubernetes-engine/docs/how-to/dcgm-metrics) | Failed: Network error: Internal Server Error

### Errors in kubecost-cloud/kubecost-cloud-cloud-billing-integrations/kubecost-cloud-gcp-integration.md

* [500] [https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#detailed-usage-cost-data-schema](https://cloud.google.com/billing/docs/how-to/export-data-bigquery-tables#detailed-usage-cost-data-schema) | Cached: Error (cached)

@thomasvn
Copy link
Member Author

Link checker passed this time. Re-requesting reviews.

@chipzoller chipzoller merged commit 69538da into main Dec 11, 2024
5 checks passed
@chipzoller chipzoller deleted the thomasn/dcgm-exporter-more-validation branch December 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants