Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions run by handling go-gitlint tool installation #108

Closed
wants to merge 1 commit into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Dec 26, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

I created this PR to address this rule:

"None"

Description

This PR addresses the issue where the GitHub Actions run was failing due to the go-gitlint tool not being found. The commit-msg script has been modified to check if the go-gitlint tool exists before trying to run it. If it does not exist, the script attempts to install it using the 'make tools' command. If the installation is successful, the script then proceeds to run the go-gitlint tool. If the installation fails, the script prints an error message and exits with a non-zero status code.

Summary of Changes

  • Added a check in the commit-msg script to see if the go-gitlint tool exists before trying to run it.
  • If the go-gitlint tool does not exist, the script attempts to install it using the 'make tools' command.
  • If the 'make tools' command is successful, the script proceeds to run the go-gitlint tool.
  • If the go-gitlint tool still does not exist after attempting to install it, the script prints an error message and exits with a non-zero status code.

@sweep-ai sweep-ai bot requested a review from cubxxw as a code owner December 26, 2023 18:15
Copy link
Contributor Author

sweep-ai bot commented Dec 26, 2023

Rollback Files For Sweep

  • Rollback changes to scripts/githooks/commit-msg
  • Rollback changes to scripts/githooks/commit-msg

@sweep-ai sweep-ai bot requested a review from kubbot as a code owner December 26, 2023 18:15
@sweep-ai sweep-ai bot added the sweep label Dec 26, 2023
Copy link
Contributor Author

sweep-ai bot commented Dec 26, 2023

Sandbox Executions

  • Running GitHub Actions for scripts/githooks/commit-msg
Check scripts/githooks/commit-msg with contents:

Ran GitHub Actions for c55699ad918710f6ab2054a92f29743f4d992654:

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 26, 2023
Copy link
Contributor Author

sweep-ai bot commented Dec 26, 2023

The command:
Run ./tools/typos ./CONTRIBUTING.md ./README.md
yielded the following error:
##[error]Process completed with exit code 127.
Here are the logs:

/home/runner/work/_temp/56f2e49a-0c21-41ea-b8c8-2214328f21c6.sh: line 1: ./tools/typos: No such file or directory

@kubbot kubbot removed the sweep label Dec 30, 2023
@kubbot
Copy link
Member

kubbot commented Feb 16, 2024

This issue is stale because it has been open 7 days with no activity.

@kubbot kubbot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2024
@kubbot
Copy link
Member

kubbot commented Feb 21, 2024

This PR was closed because it has been stalled for 5 days with no activity. You can reopen it if you want.

@kubbot kubbot closed this Feb 21, 2024
@kubecub kubecub locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants