Set maxscale Field Optional (#1389)

Signed-off-by: SK Ali Arman <arman@appscode.com>
kubedb · Jan 30, 2025 · e37dc98 · e37dc98
1 parent e5366d5
commit e37dc98
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/apis/catalog/v1alpha1/mariadb_version_helpers.go b/apis/catalog/v1alpha1/mariadb_version_helpers.go
@@ -56,14 +56,12 @@ func (m MariaDBVersion) ValidateSpecs() error {
 	if m.Spec.Version == "" ||
 		m.Spec.DB.Image == "" ||
 		m.Spec.Exporter.Image == "" ||
-		m.Spec.Maxscale.Image == "" ||
 		m.Spec.InitContainer.Image == "" ||
 		m.Spec.Coordinator.Image == "" {
 		return fmt.Errorf(`atleast one of the following specs is not set for mariadbversion "%v":
 spec.version,
 spec.db.image,
 spec.exporter.image,
-spec.maxscale.image,
 spec.initContainer.image,
 spec.coordinator.image.`, m.Name)
 	}

diff --git a/apis/catalog/v1alpha1/mariadb_version_types.go b/apis/catalog/v1alpha1/mariadb_version_types.go
@@ -55,6 +55,7 @@ type MariaDBVersionSpec struct {
 	// Database Image
 	DB MariaDBVersionDatabase `json:"db"`
 	// Maxscale Image
+	// +optional
 	Maxscale MariaDBVersionMaxscale `json:"maxscale"`
 	// Exporter Image
 	Exporter MariaDBVersionExporter `json:"exporter"`

diff --git a/apis/catalog/v1alpha1/openapi_generated.go b/apis/catalog/v1alpha1/openapi_generated.go
diff --git a/crds/catalog.kubedb.com_mariadbversions.yaml b/crds/catalog.kubedb.com_mariadbversions.yaml
@@ -246,7 +246,6 @@ spec:
             - db
             - exporter
             - initContainer
-            - maxscale
             - podSecurityPolicies
             - version
             type: object