Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Monitoring doc #379

Merged
merged 23 commits into from
Jan 7, 2019
Merged

Update Monitoring doc #379

merged 23 commits into from
Jan 7, 2019

Conversation

hossainemruz
Copy link
Contributor

@hossainemruz hossainemruz commented Jan 2, 2019 •
edited
Loading

Task:

  • Add database monitoring overview
  • Update doc:
    • Elasticsearch
    • PostgreSQL
    • MongoDB
    • MySQL
    • Redis
    • Memcached

tamalsaha
tamalsaha reviewed Jan 3, 2019
View reviewed changes
docs/guides/redis/monitoring/using-builtin-prometheus.md Outdated
prometheus.io/path: ...
prometheus.io/port: ...
prometheus.io/scrape: ...
- job_name: 'kubernetes-service-endpoints'
Copy link
Member

@tamalsaha tamalsaha Jan 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we targeting this specific service? I think we need to add a keep action for __meta_kubernetes_service_annotation_prometheus_io_port.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not. It is generic configuration. User may have already have this configuration to monitor other resources. So, they don't need to update anything.

tamalsaha
tamalsaha reviewed Jan 3, 2019
View reviewed changes
docs/guides/redis/monitoring/using-builtin-prometheus.md
```

Now, the below yaml is used to deploy Prometheus in kubernetes:
**Create RBAC:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add this section separately? We should just add this into the deployment.yaml and always create the RABC objects.

Copy link
Contributor Author

@hossainemruz hossainemruz Jan 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make users aware of what RBAC permissions are given.

@tamalsaha tamalsaha merged commit e98d128 into master Jan 7, 2019
@tamalsaha tamalsaha deleted the monitoring branch January 7, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamalsaha tamalsaha tamalsaha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hossainemruz @tamalsaha