Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate summary report & compare #65

Merged
merged 8 commits into from
Jun 21, 2017
Merged

Generate summary report & compare #65

merged 8 commits into from
Jun 21, 2017

Conversation

mirshahriar
Copy link
Contributor

No description provided.

shahriar added 7 commits June 19, 2017 11:38
# Conflicts:
#	glide.lock
#	vendor/k8s.io/kubernetes/pkg/version/base.go
@mirshahriar mirshahriar requested a review from tamalsaha June 21, 2017 11:11
@tamalsaha tamalsaha changed the title generate audit report & compare Generate summary report & compare Jun 21, 2017
@tamalsaha
Copy link
Member

I think one more change will be to use the url.URL to generate the ?index= part, so that proper url encoding is used. Otherwise looks good.

@tamalsaha tamalsaha merged commit ac41afc into master Jun 21, 2017
@tamalsaha tamalsaha deleted the audit branch June 21, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants