Fix downstream bug in IL #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
size/S
bug: after deleting dataset, the event of deleting job can not be sent to LC. Signed-off-by: JimmyYang20 <yangjin39@huawei.com>
|
/lgtm |
Poorunga
reviewed
May 24, 2022
| ds, err := c.client.Datasets(job.Namespace).Get(context.TODO(), dataName, metav1.GetOptions{}) | ||
| if err != nil { | ||
| return fmt.Errorf("dataset(%s/%s) not found", job.Namespace, dataName) | ||
| klog.Errorf("not found job(name=%s/%s)'s dataset, error: %v", job.Kind, job.Name, err) |
There was a problem hiding this comment.
There is no return here, maybe dsNodeName will be empty in the function below:
if eventType == watch.Deleted {
// delete jobs from all LCs
nodes := sets.NewString(dsNodeName, trainNodeName, evalNodeName, deployNodeName)
for node := range nodes {
c.sendToEdgeFunc(node, eventType, job)
}
return nil
}
dsNodeName in sets.NewString(dsNodeName, trainNodeName, evalNodeName, deployNodeName) maybe an empty string.
There was a problem hiding this comment.
the func sendToEdgeFunc will handle the case where the node is empty.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypume The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: after deleting dataset, the event of deleting job can be sent to LC.
Signed-off-by: JimmyYang20 yangjin39@huawei.com