LL: support schedule workers on multi-nodes #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JimmyYang20 <yangjin39@huawei.com>
kubeedge-bot
added
the
size/XXL
Poorunga
reviewed
May 24, 2022
| } | ||
|
|
||
| doJobStageEvent := func(nodeName string) { | ||
| if currentType == sednav1.LLJobStageCondWaiting { |
There was a problem hiding this comment.
Can we use swich to replace multiple if...else, like:
switch currentType {
case sednav1.LLJobStageCondWaiting:
...
case sednav1.LLJobStageCondRunning:
...
case sednav1.LLJobStageCondCompleted, sednav1.LLJobStageCondFailed
...
}
| "fmt" | ||
| "k8s.io/apimachinery/pkg/types" |
There was a problem hiding this comment.
Follow the import order of go packages:
- built-in packages
- third-party packages
- self-packages
| continue | ||
| } | ||
|
|
||
| if err != nil { | ||
| klog.Errorf("job(name=%s) complete the %s task failed, error: %v", | ||
| jobConfig.UniqueIdentifier, jobConfig.Phase, err) | ||
| klog.Errorf("job(%s) failed to complete the %s task: %v", name, jobStage, err) | ||
| } | ||
|
|
||
| <-tick.C |
There was a problem hiding this comment.
Suggested usage of ticker:
for {
select {
case <-job.JobConfig.Done:
return
case <-tick.C:
...
default:
...
}
}
| func (lm *Manager) initJob(job *Job) error { | ||
| func (lm *Manager) initJob(job *Job, name string) error { | ||
| var err error | ||
| job.JobConfig = new(JobConfig) |
There was a problem hiding this comment.
This is not a good way to write code, it is recommended to:
jobConfig := new(JobConfig)
jobConfig.xxx = xxx
...
job.JobConfig = jobConfig
|
/lgtm |
worker's spec supports nodeName and nodeSelector Signed-off-by: JimmyYang20 <yangjin39@huawei.com>
JimmyYang20
force-pushed
the
fixbug-lifelong
branch
from
a4b89b6 to
104943d
Compare
jaypume
approved these changes
May 24, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypume The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worker's spec supports nodeName and nodeSelector
Signed-off-by: JimmyYang20 yangjin39@huawei.com