Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstructured Sedna Lifelong Learning Architecture #392

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Unstructured Sedna Lifelong Learning Architecture #392

merged 4 commits into from
Mar 31, 2023

Conversation

luosiqi
Copy link
Contributor

@luosiqi luosiqi commented Jan 19, 2023

In this PR, unstructured Sedna lifelong learning architecture is achieved. It surpports the following new features.

  • Unstructured lifelong learning
  • Unseen task detection
  • Online unseen task processing
  • Offline unseen task training

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 19, 2023
JimmyYang20
JimmyYang20 reviewed Jan 19, 2023
View reviewed changes
examples/lifelong_learning/robot_dog_delivery/RFNet/basemodel.py Outdated
@@ -17,7 +17,7 @@
from utils.args import TrainingArguments, EvaluationArguments
from estimators.train import Trainer
from estimators.eval import Validator, load_my_state_dict
from accuracy import robo_accuracy
from accuracy import accuracy

os.environ["BACKEND_TYPE"] = ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env var's default value is ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Feb 7, 2023
View reviewed changes
lib/sedna/algorithms/seen_task_learning/task_allocation/base_task_allocation.py Outdated
@@ -0,0 +1,30 @@
"""
Mining tasks of inference sample base on task attribute extractor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base on -> based on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

MooreZheng
MooreZheng reviewed Feb 7, 2023
View reviewed changes
examples/lifelong_learning/robot_dog_delivery/README.md
Before this, user must provide an s3 directory for storage which is denoted as "s3_prefix" in this example, by setting environment variable s3_prefix.
```
s3_prefix=$s3_prefix
cloud_image=swr.cn-south-1.myhuaweicloud.com/sedna/sedna-robo:v0.1.1
Copy link
Contributor

@MooreZheng MooreZheng Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user needs to change the image, it shall be done in the configuration instead of after dataset preparation. Add an introduction to the image (as ``prepare image'' introduced below).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MooreZheng
Copy link
Contributor

My comment is addressed in the current version.
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@jaypume
Copy link
Member

jaypume commented Feb 13, 2023

For commit history of Sedna repository more readable and cleaner, I suggest to squash the commits by git rebase -i kubeedge/main, to keep the number of commit to 3~5, and to make the commit message more concrete, instead of "update this... imporve that"

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@MooreZheng
Copy link
Contributor

/lgtm

@kubeedge-bot kubeedge-bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/contains-merge-commits and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/contains-merge-commits labels Mar 29, 2023
@jaypume
Copy link
Member

jaypume commented Mar 31, 2023

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@jaypume
Copy link
Member

jaypume commented Mar 31, 2023

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@kubeedge-bot kubeedge-bot merged commit 2a003ec into kubeedge:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmyYang20 JimmyYang20 JimmyYang20 left review comments

@MooreZheng MooreZheng MooreZheng left review comments

@TymonXie TymonXie Awaiting requested review from TymonXie

Assignees

@jaypume jaypume

@MooreZheng MooreZheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luosiqi @MooreZheng @jaypume @kubeedge-bot @JimmyYang20