Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Breaking Changes: Migrate model subcommand to model analyze #1060

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ChenYi015
Copy link
Collaborator

@ChenYi015 ChenYi015 commented Mar 26, 2024

What this PR does / why we need it:

Migrate arena model subcommand to arena model analyze.

Which issue(s) this PR fixes:
Fixes #1061

Copy link

google-cla bot commented Mar 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ChenYi015 ChenYi015 force-pushed the migrate branch 2 times, most recently from ab55173 to a135fa6 Compare March 26, 2024 12:47
@Syulin7 Syulin7 changed the title Migrate model subcommand to analyze ⚠️ Breaking Changes: Migrate model subcommand to analyze Mar 27, 2024
@Syulin7
Copy link
Collaborator

Syulin7 commented Mar 27, 2024

@ChenYi015 Thanks! Looks good. Can you do a rebase?

@ChenYi015
Copy link
Collaborator Author

@ChenYi015 Thanks! Looks good. Can you do a rebase?

Done!

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015 ChenYi015 changed the title ⚠️ Breaking Changes: Migrate model subcommand to analyze ⚠️ Breaking Changes: Migrate model subcommand to model analyze Mar 27, 2024
@Syulin7
Copy link
Collaborator

Syulin7 commented Mar 27, 2024

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, Syulin7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 12f205e into kubeflow:master Mar 27, 2024
5 checks passed
@Syulin7 Syulin7 mentioned this pull request Apr 10, 2024
@ChenYi015 ChenYi015 deleted the migrate branch September 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Breaking Changes: Migrate model subcommand to model analyze
2 participants