#1121 Support multiple type devices #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhiboo
force-pushed
the
support-domestic-chip
branch
2 times, most recently
from
c487bf3 to
f67a90c
Compare
cheyang
reviewed
Aug 29, 2024
cheyang
requested changes
Aug 29, 2024
|
@lizhiboo Thank you for this great contribution. Please rebase your PR |
lizhiboo
force-pushed
the
support-domestic-chip
branch
2 times, most recently
from
10ff039 to
5eb40c8
Compare
Syulin7
reviewed
Aug 30, 2024
lizhiboo
force-pushed
the
support-domestic-chip
branch
from
f1beced to
74923fd
Compare
Syulin7
reviewed
Sep 2, 2024
sdk/arena-java-sdk/src/test/java/com/github/kubeflow/arena/PyTorchJobTest.java
Outdated
Show resolved
Hide resolved
lizhiboo
force-pushed
the
support-domestic-chip
branch
2 times, most recently
from
531dc10 to
50750f8
Compare
|
/lgtm |
…, such as amd.com/gpu=1 Signed-off-by: lizhiboo <lizhiboo@yeah.net>
lizhiboo
force-pushed
the
support-domestic-chip
branch
from
35d520e to
7189cc0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1121
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #