Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add success policy to TF training job #1148

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Add success policy to TF training job #1148

merged 3 commits into from
Sep 29, 2024

Conversation

ChenYi015
Copy link
Collaborator

Purpose of this PR

Proposed changes:

  • Add success policy to TF training job

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

@ChenYi015 ChenYi015 marked this pull request as ready for review September 20, 2024 03:58
@ChenYi015
Copy link
Collaborator Author

/assign @cheyang @Syulin7

cheyang
cheyang requested changes Sep 20, 2024
View reviewed changes
pkg/argsbuilder/submit_tfjob.go Outdated Show resolved Hide resolved
@ChenYi015 ChenYi015 force-pushed the feature/tfjob-success-policy branch from 369f60a to f0b6e20 Compare September 20, 2024 06:16
@ChenYi015 ChenYi015 requested a review from cheyang September 20, 2024 06:17
@ChenYi015 ChenYi015 force-pushed the feature/tfjob-success-policy branch from f0b6e20 to 785d997 Compare September 29, 2024 07:26
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Sep 29, 2024
@ChenYi015
Add successPolicy field to tfjob CRD
938037e 
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Add successPolicy to TFJob charts
7feb0ec 
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Add success-policy flags
95ef8eb 
Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015 ChenYi015 force-pushed the feature/tfjob-success-policy branch from 785d997 to 95ef8eb Compare September 29, 2024 09:16
@google-oss-prow google-oss-prow bot added size/XXL and removed size/M labels Sep 29, 2024
cheyang
cheyang approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 29, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang requested a review from happy2048 September 29, 2024 09:30
@google-oss-prow google-oss-prow bot merged commit 11b771b into kubeflow:master Sep 29, 2024
5 checks passed
@ChenYi015 ChenYi015 deleted the feature/tfjob-success-policy branch September 29, 2024 13:35
ChenYi015 added a commit to ChenYi015/arena that referenced this pull request Oct 11, 2024
@ChenYi015
Revert "Add success policy to TF training job (kubeflow#1148)"
23bc4ba 
This reverts commit 11b771b.
@ChenYi015 ChenYi015 mentioned this pull request Oct 11, 2024
Merged
ChenYi015 added a commit to ChenYi015/arena that referenced this pull request Oct 11, 2024
@ChenYi015
Revert "Add success policy to TF training job (kubeflow#1148)"
9013a51 
This reverts commit 11b771b.

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015 ChenYi015 mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang approved these changes

@wsxiaozhang wsxiaozhang Awaiting requested review from wsxiaozhang

@xiaozhouX xiaozhouX Awaiting requested review from xiaozhouX

@happy2048 happy2048 Awaiting requested review from happy2048

Assignees

@cheyang cheyang

@Syulin7 Syulin7

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChenYi015 @cheyang @happy2048 @Syulin7