Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GKE #58

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Support GKE #58

merged 1 commit into from
Sep 19, 2018

Conversation

mrkm4ntr
Copy link
Contributor

@mrkm4ntr mrkm4ntr commented Sep 19, 2018

Support GKE.
vendor/k8s.io/client-go/plugin/* is not included in the source tree, so I ran dep ensure.


This change is Reviewable

@cheyang
Copy link
Collaborator

cheyang commented Sep 19, 2018

Thank you for your contribution. Sorry, I'm not familiar with GKE. Could you please clarify the reason of adding GKE vendor? Did it cause arena fail in GKE? Can you explain a little more. Thanks very much.

@mrkm4ntr
Copy link
Contributor Author

mrkm4ntr commented Sep 19, 2018

If there isn't this line, it causes following error.

$ arena list
FATA[0000] No Auth Provider found for name "gcp"

More information is here.
GKE modules are added to the vendor by adding above import.

@cheyang
Copy link
Collaborator

cheyang commented Sep 19, 2018

Understand! Thanks very much.

@cheyang
Copy link
Collaborator

cheyang commented Sep 19, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang added the problems/bug Something isn't working label Sep 19, 2018
@cheyang
Copy link
Collaborator

cheyang commented Sep 19, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit b646080 into kubeflow:master Sep 19, 2018
@mrkm4ntr mrkm4ntr deleted the support-gke branch September 20, 2018 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants