Change the default value of CleanPodPolicy to None and fix golangci-l…

…int staticcheck. Signed-off-by: Syulin7 <735122171@qq.com>
kubeflow · Feb 13, 2023 · 43e3a2e · 43e3a2e
1 parent 9ec55d1
commit 43e3a2e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/apis/common/v1/openapi_generated.go b/pkg/apis/common/v1/openapi_generated.go
diff --git a/pkg/apis/common/v1/types.go b/pkg/apis/common/v1/types.go
@@ -179,7 +179,7 @@ const (
 // active.
 type RunPolicy struct {
 	// CleanPodPolicy defines the policy to kill pods after the job completes.
-	// Default to Running.
+	// Default to None.
 	CleanPodPolicy *CleanPodPolicy `json:"cleanPodPolicy,omitempty"`
 
 	// TTLSecondsAfterFinished is the TTL to clean up jobs.

diff --git a/pkg/controller.v1/common/job_test.go b/pkg/controller.v1/common/job_test.go
@@ -191,7 +191,7 @@ func TestCleanupJobIfTTL(T *testing.T) {
 	}
 	oneDayAgo := time.Now()
 	// one day ago
-	oneDayAgo.AddDate(0, 0, -1)
+	_ = oneDayAgo.AddDate(0, 0, -1)
 	jobStatus := apiv1.JobStatus{
 		CompletionTime: &metav1.Time{
 			Time: oneDayAgo,