Failed to fetch common module

[Jeffwan]

Following command doesn't work.

$ go get github.com/kubeflow/common
go: finding github.com/kubeflow/common latest
go get: github.com/kubeflow/common@v0.0.0-20200413165349-fda69c7bdd38 requires
	k8s.io/kubernetes@v1.18.0 requires
	k8s.io/kubectl@v0.0.0: reading k8s.io/kubectl/go.mod at revision v0.0.0: unknown revision v0.0.0

I think this is because of #62.

I use the stable version here for now and I will fix this when I get time.

$ go get github.com/kubeflow/common@v0.0.0-20200327002023-0b3a4c3fca85
go: finding github.com/kubeflow/common v0.0.0-20200327002023-0b3a4c3fca85
go: downloading github.com/kubeflow/common v0.0.0-20200327002023-0b3a4c3fca85
go: extracting github.com/kubeflow/common v0.0.0-20200327002023-0b3a4c3fca85

[issue-label-bot]

Issue-Label Bot is automatically applying the labels:

Label	Probability
bug	0.86

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

[k82cn]

@hzxuzhonghu , please also help to check this :)

[hzxuzhonghu]

/assign

[hzxuzhonghu]

@Jeffwan It is not the pr i filed introduced this issue.

go get github.com/kubeflow/common@461336009d7f8e9c97db6de123265accce7e7e36
go: finding github.com 461336009d7f8e9c97db6de123265accce7e7e36
go: finding github.com/kubeflow/common 461336009d7f8e9c97db6de123265accce7e7e36
go: finding github.com/kubeflow 461336009d7f8e9c97db6de123265accce7e7e36
go: downloading github.com/kubeflow/common v0.0.0-20200413165149-461336009d7f
go: extracting github.com/kubeflow/common v0.0.0-20200413165149-461336009d7f
go get: github.com/kubeflow/common@v0.0.0-20200413165149-461336009d7f requires
	k8s.io/kubernetes@v1.15.10 requires
	k8s.io/api@v0.0.0: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0

[hzxuzhonghu]

with go get github.com/kubeflow/common@v0.0.0-20200327002023-0b3a4c3fca85 i still get the same error

[hzxuzhonghu]

Not sure why, it is weird how i can import latest from tf-operator.

kubeflow/training-operator#1152

[Jeffwan]

@hzxuzhonghu I am not 100% sure this is related to the PR. Technically, once we replace libraries, it should be fine. Let me double check my environment.

I can confirm that if I import this separately, both latest and previous one won't work. This is expected because go.mod in current project ( not kubeflow/common) doesn't have replace.
If I update it inside a project, latest doesn't work for me and previous commit works.

[Jeffwan]

@hzxuzhonghu @k82cn I think I figure it out. Sorry about the confusion. If one project doesn't have all component replaced, it may have this issue. In order to use kubeflow/common, we need to make sure it replace all kubernetes components. In my case, mxnet-operaror miss one kubectl. that's the failure come from. Thanks for the help.

[hzxuzhonghu]

For those meeting the similar issue: kubernetes/kubernetes#79384 (comment)

[Jeffwan]

This is interesting. I notice mxnet-operator doesn't have kubectl replace can go get github.com/kubeflow/common@v0.0.0-20200327002023-0b3a4c3fca85 successfully.

I think the problem is more on the Kubernetes side. most of the components including kfctl have been moved to staging in 1.16.x which means kubernetes use v0.0.0 for reference. This means we don't need kfctl override in the project untill we graduate to kubernetes 1.16 and above.

Since we upgrade to 1.18 in PR #62, this requires a change on the operator which uses this lib to have a separate record to override kfctl.