Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate labels from profile custom resource to controller-generated namespace #51

Open
droctothorpe opened this issue Feb 22, 2024 · 2 comments · May be fixed by kubeflow/kubeflow#7481

Comments

@droctothorpe
Copy link

/kind feature

Why you need this feature:
We use the profile operator directly instead of pathing through the UI. We want end user namespaces to have specific labels (that identify various things about the user). This code lets administrators set global namespace labels, but there's no mechanism to pass custom-resource-specific, non-global labels.

Describe the solution you'd like:
The simplest way to implement this is to just propagate labels from the profile custom resource to the corresponding namespace. It's a one line change to the controller logic.

Anything else you would like to add:
I'll submit a PR momentarily.

@andreyvelich
Copy link
Member

/transfer dashboard

Copy link

@droctothorpe: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature

Why you need this feature:
We use the profile operator directly instead of pathing through the UI. We want end user namespaces to have specific labels (that identify various things about the user). This code lets administrators set global namespace labels, but there's no mechanism to pass custom-resource-specific, non-global labels.

Describe the solution you'd like:
The simplest way to implement this is to just propagate labels from the profile custom resource to the corresponding namespace. It's a one line change to the controller logic.

Anything else you would like to add:
I'll submit a PR momentarily.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot transferred this issue from kubeflow/kubeflow Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

2 participants