Skip to content

Commit

Permalink
Cherry pick: Remove code generation from release script (#2363) (#2364)
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
  • Loading branch information
andreyvelich authored Jun 20, 2024
1 parent 1c45521 commit 343b941
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,12 @@ push-latest: generate
bash scripts/v1beta1/push.sh $(KATIB_REGISTRY) $(COMMIT)

# Build and push Katib images for the given tag.
push-tag: generate
push-tag:
ifeq ($(TAG),)
$(error TAG must be set. Usage: make push-tag TAG=<release-tag>)
endif
bash scripts/v1beta1/build.sh $(KATIB_REGISTRY) $(TAG) $(CPU_ARCH)
bash scripts/v1beta1/build.sh $(KATIB_REGISTRY) $(COMMIT) $(CPU_ARCH)
bash scripts/v1beta1/push.sh $(KATIB_REGISTRY) $(TAG)
bash scripts/v1beta1/push.sh $(KATIB_REGISTRY) $(COMMIT)

# Release a new version of Katib.
release:
Expand Down
2 changes: 0 additions & 2 deletions scripts/v1beta1/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ if [[ ${sdk_version} == *"-rc."* ]]; then
sdk_version=${sdk_version//-rc./rc}
fi
echo -e "\nPublishing Katib Python SDK, version: ${sdk_version}\n"
# Run generate script.
make generate

# Change version in setup.py
cd sdk/python/v1beta1
Expand Down

0 comments on commit 343b941

Please sign in to comment.