Fix: Add taskruns to Katib controller role to run Tekton Pipelines (#…

…1380) * Add taskruns to controller role * Condition in one line
kubeflow · Nov 7, 2020 · a96ff59 · a96ff59
1 parent 6dc1af8
commit a96ff59
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/manifests/v1beta1/katib-controller/rbac.yaml b/manifests/v1beta1/katib-controller/rbac.yaml
@@ -77,6 +77,7 @@ rules:
       - tekton.dev
     resources:
       - pipelineruns
+      - taskruns
     verbs:
       - "*"
   - apiGroups:

diff --git a/pkg/webhook/v1beta1/pod/inject_webhook.go b/pkg/webhook/v1beta1/pod/inject_webhook.go
@@ -70,11 +70,10 @@ func (s *sidecarInjector) Handle(ctx context.Context, req types.Request) types.R
 	// Check whether the pod need to be mutated
 	needMutate, err := s.MutationRequired(pod, namespace)
 	if err != nil {
+		log.Info("Unable to run MutationRequired", "Error", err)
 		return admission.ErrorResponse(http.StatusInternalServerError, err)
-	} else {
-		if !needMutate {
-			return admission.ValidationResponse(true, "")
-		}
+	} else if !needMutate {
+		return admission.ValidationResponse(true, "")
 	}
 
 	// Do mutation