We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We renamed katib-manager component to katib-db-manager: #1006, but in gRPC API we still name related service Manager: https://github.com/kubeflow/katib/blob/master/pkg/apis/manager/v1beta1/api.proto#L16-L34.
katib-manager
katib-db-manager
Manager
Maybe we should rename this service to DBManager to avoid confusions, since we add only DB-related API there?
DBManager
This APIs services are under /apis/manager directory which also sounds not clear.
/apis/manager
I think we should say that: Katib has gRPC manager which supports:
service DBManager
service Suggestion
service EarlyStopping
What do you think @gaocegege @johnugeorge ?
/kind question
The text was updated successfully, but these errors were encountered:
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! Links: app homepage, dashboard and code for this bot.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
We renamed
katib-manager
component tokatib-db-manager
: #1006, but in gRPC API we still name related serviceManager
: https://github.com/kubeflow/katib/blob/master/pkg/apis/manager/v1beta1/api.proto#L16-L34.Maybe we should rename this service to
DBManager
to avoid confusions, since we add only DB-related API there?This APIs services are under
/apis/manager
directory which also sounds not clear.I think we should say that: Katib has gRPC manager which supports:
service DBManager
- Service to call DB-related APIs.service Suggestion
- Service to call Suggestion-related APIs.service EarlyStopping
- Service to call Early Stopping-related APIs.What do you think @gaocegege @johnugeorge ?
/kind question
The text was updated successfully, but these errors were encountered: