Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Manager service name #1244

Closed
andreyvelich opened this issue Jun 26, 2020 · 2 comments · Fixed by #1279
Closed

DB Manager service name #1244

andreyvelich opened this issue Jun 26, 2020 · 2 comments · Fixed by #1279

Comments

@andreyvelich
Copy link
Member

We renamed katib-manager component to katib-db-manager: #1006, but in gRPC API we still name related service Manager: https://github.com/kubeflow/katib/blob/master/pkg/apis/manager/v1beta1/api.proto#L16-L34.

Maybe we should rename this service to DBManager to avoid confusions, since we add only DB-related API there?

This APIs services are under /apis/manager directory which also sounds not clear.

I think we should say that: Katib has gRPC manager which supports:

  1. service DBManager - Service to call DB-related APIs.
  2. service Suggestion - Service to call Suggestion-related APIs.
  3. service EarlyStopping - Service to call Early Stopping-related APIs.

What do you think @gaocegege @johnugeorge ?

/kind question

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.69

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

1 similar comment
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.69

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants