Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename katib DB manager #1006

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Rename katib DB manager #1006

merged 1 commit into from
Jan 9, 2020

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Jan 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1004

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@johnugeorge
Copy link
Member

Should we wait till next API release?

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@hougangliu
Copy link
Member Author

Should we wait till next API release?

I think this PR only changes service name, API uninvolved.

@johnugeorge
Copy link
Member

I meant, installation via Katib repo and manifest repo will be inconsistent. I am not sure if it is a problem

@hougangliu
Copy link
Member Author

I meant, installation via Katib repo and manifest repo will be inconsistent. I am not sure if it is a problem

I think there is no problem. in katib repo, we always use latest images; and in manifest repo, we use a certain tag (now it's 0.7 in manifest master). that is, when upgrade katib repo (latest images), manifest repo is not affected.

@hougangliu
Copy link
Member Author

/cc @johnugeorge @gaocegege

@johnugeorge
Copy link
Member

/lgtm

@hougangliu
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a0f75d1 into kubeflow:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename katib-manager and katib-db
3 participants