Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Test breakage #1433

Closed
yanniszark opened this issue Feb 15, 2021 · 2 comments
Closed

e2e: Test breakage #1433

yanniszark opened this issue Feb 15, 2021 · 2 comments
Labels

Comments

@yanniszark
Copy link
Contributor

/kind bug

What steps did you take and what happened:
E2E tests are not succeeding because they can't install the tf-operator manifests:

cd "${MANIFESTS_DIR}/tf-training/tf-job-crds/base"

This is an artifact of using the manifests master branch to install the tf-operator.
A recent folder restructuring in manifests is what triggered it:
kubeflow/manifests#1738
kubeflow/manifests#1739

What did you expect to happen:
E2E tests should succeed.

Anything else you would like to add:
This is an artifact of using the manifests master branch to install the tf-operator.
As master is not guarranteed to be stable or avoid any folder renames, the e2e tests for katib broke.

These are the possible solutions:

  • Pin the manifests version to the latest stable release (v1.2). This will prevent it from breaking in the future and I think is the best choice. We can update it regularly as with other deps.
  • Change the directories they use to the new ones.

I recommend the first approach. If you agree, I can make a quick PR.

cc @kubeflow/wg-automl-leads

@andreyvelich
Copy link
Member

I agree with the first approach since we can verify our e2e test on the latest stable training operator releases.
It would be great if you can submit the PR @yanniszark!

@andreyvelich
Copy link
Member

Fixed by: #1438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants