Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pin manifests to stable v1.2-branch #1436

Closed

Conversation

yanniszark
Copy link
Contributor

@yanniszark yanniszark commented Feb 17, 2021

What this PR does / why we need it:
Fixes the e2e tests by pinning the kubeflow/manifests dependency to a stable branch.

Which issue(s) this PR fixes:
Fixes #1433

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanniszark
To complete the pull request process, please assign johnugeorge after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@yanniszark yanniszark force-pushed the feature-pin-manifests-dependency branch from 981ce1e to 9edff8d Compare February 17, 2021 13:04
@yanniszark
Copy link
Contributor Author

/retest

1 similar comment
@yanniszark
Copy link
Contributor Author

/retest

@yanniszark
Copy link
Contributor Author

@andreyvelich some seemingly unrelated tests are failing:
build-suggestion-optuna, build-file-metrics-collector, build-db-manager, build-katib-controller.
The logs are not very helpful.

INFO[0046] Running: [/bin/sh -c if [ "$(uname -m)" = "ppc64le" ] || [ "$(uname -m)" = "aarch64" ]; then     apk --update add gcc musl-dev  &&     go build -o goptuna-suggestion
 ./v1beta1;     else     go build -o goptuna-suggestion ./v1beta1;     fi]
go: cannot find main module, but found Gopkg.lock in /go/src/github.com/kubeflow/katib
        to create a module there, run:
        cd ../../.. && go mod init
error building image: error building stage: failed to execute command: waiting for process to exit: exit status 1

Have you seen this before?

@andreyvelich
Copy link
Member

I will check it.
/retest

@aws-kf-ci-bot
Copy link
Contributor

@yanniszark: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 9edff8d link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andreyvelich
Copy link
Member

It seems that we have to switch to go modules to fix these errors.
I submitted PR: #1438 to implement it.

I think we can close this PR, thank you for investigation @yanniszark !

@yanniszark
Copy link
Contributor Author

@andreyvelich thanks for taking the time to fix CI :)
Seems like it was a quite involved fix.

@yanniszark yanniszark closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: Test breakage
4 participants