-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Pin manifests to stable v1.2-branch #1436
test: Pin manifests to stable v1.2-branch #1436
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yanniszark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
981ce1e
to
9edff8d
Compare
/retest |
1 similar comment
/retest |
@andreyvelich some seemingly unrelated tests are failing:
Have you seen this before? |
I will check it. |
@yanniszark: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
It seems that we have to switch to go modules to fix these errors. I think we can close this PR, thank you for investigation @yanniszark ! |
@andreyvelich thanks for taking the time to fix CI :) |
What this PR does / why we need it:
Fixes the e2e tests by pinning the kubeflow/manifests dependency to a stable branch.
Which issue(s) this PR fixes:
Fixes #1433