-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate Katib Releases #2049
Comments
We can use a |
@andreyvelich Thanks for proposing this.
That's right. For now, we can not release multi-platform images by that documentation's steps.
I agree with you.
I prefer to use the release trigger. |
If we could prepare arm-machine self-hosted runner(or use github action arm runner with extra charge), we could make the automate release. How could we prepare the arm machine ? |
@anencore94 |
@tenzen-y I mean if we prepare arm-machine runners, we could build arm-platform images at github-action workflows much easier and then publish them by manifests including both amd and arm image. WDYT ? I'm not sure we need to enable |
@anencore94 I see. We can build multiplatform images using the default amd64 runner. Actually, we publish multi-platform images for every commit like this. Probably, we don't need arm64 runners for the multi-platform build. Does that sound good to you? |
Sure, But building an arm-image in amd64-runner would be much slower since it uses some kind of virtualizer like QEMU to build arm-image. |
@anencore94 I see. That's a great idea, I agree with your idea. It makes speed up building time if we could prepare arm64 runners.
https://docs.docker.com/build/building/multi-platform/#building-multi-platform-images
|
@anencore94 @tenzen-y Currently, we are not using self hosted runners. We need to review this sometime if we can use self hosted runners in AWS |
I'm willing to help create the flows for the release. Do let me know if you guys need any help once we have some agreement on runners. |
Hi @midhun1998, that would be great! |
I'd like to contribute on this automation too. see you on the next meeting :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
@andreyvelich: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue This is good issue to work on if you are familiar with GitHub actions and can help us to automate releases for Katib/Training Operator. |
@andreyvelich: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
For those tracking this issue for Arm64 support, it looks like it was actually implemented already. |
Yes, we start publishing ARM images when we run the |
Currently, to make Katib releases we have to follow this manual process: https://github.com/kubeflow/katib/tree/master/docs/release
We run
make release
command, build and publish the release Docker images locally, and publish Katib SDK version.Since we build docker images locally, our release images don't support multi OS arch: https://hub.docker.com/layers/kubeflowkatib/katib-controller/v0.14.0/images/sha256-51ca80d6005010ff08853a5f7231158cb695ea899b623200076cbc01509fc0b5?context=repo.
The release process should be automated. For example, we can utilise GitHub Actions to make Katib releases.
cc @tenzen-y @johnugeorge
Love this feature? Give it a 👍 We prioritize the features with the most 👍
The text was updated successfully, but these errors were encountered: