-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
studyJob cannot recover once Completed or Failed #291
Comments
/help |
/remove-help |
@YujiOshima can you add label |
|
This seems like its working as intended to me. Once a job reaches a terminal state (failed or succeseded) updates to the job should not be allowed. If a user wants to update the spec they could create a new job. |
Agree. K8s job works in the same way. |
/close We deprecated v1alpha1. |
@gaocegege: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Now studyJob cannot recover once Completed or Failed.
When a studyJob CRD created, I can update it by "kubectl apply" or else, but if the studyJob condition is Completed or Failed, we never start next suggestion schedule.
For example, a user creates a studyJob with an invalid workerSpec, which would lead to spawnWorker return error and studyJob goes to Failed. Then the user can correct workerSpec by "kube apply", expecting studyJob re-triggered. However, nothing will happen.
@here we should discuss the behavior of updating a studyJob CRD (when it is in RUNNING, Completed or FAILED)
The text was updated successfully, but these errors were encountered: