Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1alpha2] New UI #443

Closed
richardsliu opened this issue Mar 27, 2019 · 12 comments
Closed

[v1alpha2] New UI #443

richardsliu opened this issue Mar 27, 2019 · 12 comments
Assignees

Comments

@richardsliu
Copy link
Contributor

No description provided.

@andreyvelich
Copy link
Member

As we discussed today, after we will merge this PR: #438, we should start to work on v1alpha2 version of that New UI.
Is that correct @richardsliu @johnugeorge ?

@johnugeorge
Copy link
Member

i was suggesting to directly make changes for v1alpha2 once grpc apis are merged(this week or early next week). UI has dependency only with APIs and they can even be tested with mock data.

I feel that it might be a waste of effort by fixing for v1alpha1 and then again making new changes to v1alpha2 again.

@andreyvelich
Copy link
Member

@johnugeorge Alright

@jlewi
Copy link
Contributor

jlewi commented Apr 29, 2019

Any update on this issue?

@andreyvelich
Copy link
Member

@jlewi We have finished UI for v1alpha1 version, we just need to use new API for v1alpha2 and it will work.
@richardsliu Should we do it with 0.6 release or we can finish it to the middle of May?

@richardsliu
Copy link
Contributor Author

@andreyvelich The PR can be merged as soon as it is ready. It will be released as part of 0.6.

@jlewi
Copy link
Contributor

jlewi commented May 13, 2019

@andreyvelich What is the remaining work to close out this issue? Are we waiting on #486 to be merged?

Do we need to create a separate issue to update the kustomize manifests to use the new UI?

@andreyvelich
Copy link
Member

@jlewi Add comment here: #486 (comment).
I will add kustomize manifest after I finish the UI.

@andreyvelich
Copy link
Member

/assign

@gaocegege
Copy link
Member

Did #486 solve the issue?

@andreyvelich
Copy link
Member

Yes. We can close this issue. I will test our new UI.
/close

@k8s-ci-robot
Copy link

@andreyvelich: Closing this issue.

In response to this:

Yes. We can close this issue. I will test our new UI.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants