Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Trial pods when Experiment is deleted #611

Closed
andreyvelich opened this issue May 31, 2019 · 3 comments
Closed

Clean Trial pods when Experiment is deleted #611

andreyvelich opened this issue May 31, 2019 · 3 comments
Labels

Comments

@andreyvelich
Copy link
Member

My experiment spawns Trial and that Trial was failed. I tried to delete this Experiment, but my Trial pod was not deleted. Do we need to add additional finalizers here: https://github.com/kubeflow/katib/blob/master/pkg/controller/v1alpha2/experiment/experiment_util.go#L95 for Trial pods ?
/cc @johnugeorge @hougangliu @gaocegege
/kind bug

@gaocegege
Copy link
Member

Maybe related to #597.

@andreyvelich
Copy link
Member Author

@gaocegege You are right, the same issue. We can close it.
/close

@k8s-ci-robot
Copy link

@andreyvelich: Closing this issue.

In response to this:

@gaocegege You are right, the same issue. We can close it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants