Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add Metrics Collector Spec to Submit Experiment #1096

Merged
merged 3 commits into from
Mar 19, 2020
Merged

UI: Add Metrics Collector Spec to Submit Experiment #1096

merged 3 commits into from
Mar 19, 2020

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Mar 19, 2020 •
edited by jlewi
Loading

Fixes: #1089.

I added functionality to add Metrics Collector Spec in submit Experiment by parameters page.

It has all available Metrics Collectors:

  1. StdOut
  2. File
  3. TensorFlowEvent
  4. PrometheusMetric
  5. Custom
  6. None

MC

/cc @johnugeorge @gaocegege @hougangliu

This change is Reviewable

@johnugeorge
Copy link
Member

@andreyvelich Great work.
Is PrometheusMetric or Custom supported?

@andreyvelich
Copy link
Member Author

@johnugeorge From the UI, yes.

@johnugeorge
Copy link
Member

johnugeorge commented Mar 19, 2020 •
edited
Loading

I meant, support from backend. will user feel confused?

Looks ok to merge. we can implement it later

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c212d7c into kubeflow:master Mar 19, 2020
@andreyvelich
Copy link
Member Author

@johnugeorge Custom collector I tried with this example: https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/custom-metricscollector-example.yaml. For me it was working.

About Prometheus I am not sure that our backend supports it right now.

sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich
UI: Add Metrics Collector Spec to Submit Experiment (kubeflow#1096)
91d6323 
* Support Metrics Collector for HP Jobs

* Support metrics collector in NAS

* Change label for HP metrics regex
@andreyvelich andreyvelich deleted the issue-1089-mc-experiment-params branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege Awaiting requested review from gaocegege

@hougangliu hougangliu Awaiting requested review from hougangliu

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI Feature] Add Metrics Collector section to submit Experiment
3 participants
@andreyvelich @johnugeorge @k8s-ci-robot