Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up the Go version to 1.14.2 at Travis CI #1132

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Bump up the Go version to 1.14.2 at Travis CI #1132

merged 1 commit into from
Apr 10, 2020

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Apr 9, 2020 •
edited
Loading

What this PR does / why we need it:

In the PR #1131, I added gonum as a dependency. Then CI fails at go vet ./pkg/... because it raises syntax error at the following line:

katib/vendor/gonum.org/v1/gonum/lapack/gonum/lapack.go

Line 39 in 71a59ff

dlamchE = 0x1p-53

It seems that the above line uses the syntax added from Go 1.13. See this commit for details.

$ GOROOT=/usr/local/go1.12 /usr/local/go1.12/bin/go vet ./pkg/...
# github.com/kubeflow/katib/vendor/gonum.org/v1/gonum/lapack/gonum
vendor/gonum.org/v1/gonum/lapack/gonum/lapack.go:39:15: syntax error: unexpected p, expecting semicolon or newline or )
$

$ GOROOT=/usr/local/go1.13 /usr/local/go1.13/bin/go vet ./pkg/...
$

I checked Dockerfiles under cmd/ directory but all go versions aren't fixed. So I guess we can bump up the Go version to 1.14.2 which is the latest version.

katib/cmd/db-manager/v1alpha3/Dockerfile

Line 1 in 4fbf77d

FROM golang:alpine AS build-env

katib/cmd/katib-controller/v1alpha3/Dockerfile

Line 2 in 61e5188

FROM golang:alpine AS build-env

katib/cmd/metricscollector/v1alpha3/file-metricscollector/Dockerfile

Line 2 in c18bab6

FROM golang:alpine AS build-env

katib/cmd/ui/v1alpha3/Dockerfile

Line 8 in 4057a58

FROM golang:alpine AS go-build

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
None

Special notes for your reviewer:
None

Release note:

NONE

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @c-bata. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c-bata c-bata mentioned this pull request Apr 9, 2020
Merged
@c-bata c-bata changed the title Bump the Go version up to 1.14.2 for Travis CI Bump the Go version up to 1.14.2 at Travis CI Apr 9, 2020
@c-bata c-bata changed the title Bump the Go version up to 1.14.2 at Travis CI Bump up the Go version to 1.14.2 at Travis CI Apr 9, 2020
@c-bata
Copy link
Member Author

c-bata commented Apr 9, 2020

/ok-to-test

andreyvelich
andreyvelich reviewed Apr 9, 2020
View reviewed changes
pkg/apis/manager/v1alpha3/api.pb.go Outdated
func (*ValidateAlgorithmSettingsReply) ProtoMessage() {}
func (*ValidateAlgorithmSettingsReply) Descriptor() ([]byte, []int) {
return fileDescriptor0, []int{28}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we can edit these lines, since this file is auto generated by this script: https://github.com/kubeflow/katib/blob/master/pkg/apis/manager/v1alpha3/build.sh.
Is it possible to increase lines width for go fmt to avoid this error? In 1.12.5 version we didn't receive fmt error on these lines.

/cc @gaocegege @johnugeorge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are absolutely right.

+1 to ignore fmt error for these generated files.

andreyvelich
andreyvelich approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @gaocegege @johnugeorge

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 298b8c3 into kubeflow:master Apr 10, 2020
@c-bata c-bata deleted the update-travis-go-version branch April 10, 2020 14:55
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@c-bata @sperlingxx
Bump the Go version up to 1.14.2 for Travis CI (kubeflow#1132)
91957e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

@Akado2009 Akado2009 Awaiting requested review from Akado2009

@garganubhav garganubhav Awaiting requested review from garganubhav

@gaocegege gaocegege Awaiting requested review from gaocegege

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@andreyvelich andreyvelich

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c-bata @kubeflow-bot @k8s-ci-robot @johnugeorge @andreyvelich