Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Optimisation and enhancements for v1beta1 Katib UI #1232

Merged
merged 13 commits into from
Jun 24, 2020
Merged

UI: Optimisation and enhancements for v1beta1 Katib UI #1232

merged 13 commits into from
Jun 24, 2020

Conversation

andreyvelich
Copy link
Member

I made few improvements to increase UI productivity and make it easier to understand source code:

  1. Switch to node v12 from node v10 to make it more stable.
  2. Switch to react-scripts from using node to build and start frontend.
  3. Remove webpack, jest, babel configs/settings and remove build, start, test scripts, because react-scripts can handle all of these. If we need it, we can add them in the future.
  4. Remove unused packages from package.json that helped to reduce node_modules size by 100Mb.
  5. Modify source code to remove warnings.
  6. Add db-manager-address flag that can help to properly deploy Katib UI locally.
  7. Remove not necessary scripts imports from index.html.
  8. Remove serviceWorker
  9. Modify README.

/assign @gaocegege @johnugeorge

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Change npm install to npm ci
ede9a86 
Commit package-lock
@andreyvelich
Copy link
Member Author

andreyvelich commented Jun 23, 2020 •
edited
Loading

@gaocegege @johnugeorge It seems I should commit package-lock.json file. Ref: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5?answertab=votes#tab-top. Other projects (metadata, pipelines, centraldashboard) also have it.
It can help to avoid problems with dependencies and use npm ci instead of npm install.

@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

gaocegege
gaocegege reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @johnugeorge

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ea1746 into kubeflow:master Jun 24, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich @sperlingxx
UI: Optimisation and enhancements for v1beta1 Katib UI (kubeflow#1232)
3255558 
* UI improvements

* Add db-manager-addr flag
Modify README

* Fix graphviz

* Modify README

* Remove ID

* Add zoom to graphviz

* Remove unused scripts from index

* Fix doc

* Change npm install to npm ci
Commit package-lock

* fix npm version

* Increase max_old_space_size

* Set react-scripts to 3.2.0

* Modify doc
@andreyvelich andreyvelich deleted the ui-improvements branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@Akado2009 Akado2009 Awaiting requested review from Akado2009

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreyvelich @kubeflow-bot @johnugeorge @k8s-ci-robot @gaocegege