Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Delete ConfigMap with no Trial Templates #1260

Conversation

andreyvelich
Copy link
Member

Fixes: #1088.

If there are not Trial Templates, ConfigMap must be deleted.

I added snack boxes to inform that Templates was updated/not updated.
I renamed functions to CreateRuntimeObject, DeleteRuntimeObject, UpdateRuntimeObject in katib-client. We can use them for various k8s objects.

delete-templates

/assign @gaocegege @johnugeorge

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 9, 2020
@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f1393b9 into kubeflow:master Jul 10, 2020
@andreyvelich andreyvelich deleted the issue-1088-delete-empty-trial-configmap branch October 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Enable to delete ConfigMap with no Trial Templates
5 participants