Fix Pod's ownership to inject metrics collector #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
16 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
andreyvelich
force-pushed
the
issue-1271-pod-ownership
branch
from
30e3e23
to
7e3bbbf
Compare
|
@gaocegege @johnugeorge @sperlingxx The test passed, can you approve it again, please? |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
andreyvelich
force-pushed
the
issue-1271-pod-ownership
branch
from
b36e23a
to
7e3bbbf
Compare
|
I think we need a rebase here. |
andreyvelich
force-pushed
the
issue-1271-pod-ownership
branch
from
af3afa5
to
7952bd2
Compare
|
@gaocegege @johnugeorge I rebased |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1271.
I refactored
getKatibJobto correctly inject metrics collector.getKatibJobis looking for Trial ownership in all pod's nested objects recursively.These objects should be created ones Pod is mutated.
Also, I moved functions that are not belong to
sidecarInjectorstruct toutilsto be consistent with Validation webhook./assign @sperlingxx @gaocegege @johnugeorge