-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove istio sidecar annotation from all examples #1338
Remove istio sidecar annotation from all examples #1338
Conversation
/assign @gaocegege @johnugeorge |
/retest |
1 similar comment
/retest |
c0a9ae4
to
46d4393
Compare
After discussion with @johnugeorge, we decided to delete istio annotation from the examples. We should update documentation with this information, like we did for PyTorch Job. /cc @gaocegege |
/lgtm |
@andreyvelich: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
13ef2c9
to
3c20962
Compare
3c20962
to
2a90507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related: #1214.
I added
sidecar.istio.io/inject: "false"
to all examples.Since we support custom CRD that should be added manually.