Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Support new parameters in Trial template #1363

Conversation

andreyvelich
Copy link
Member

Fixes: #1217.

I added all parameters from TrialTemplate to submit Experiment page.
As well, user can add template YAML directly from submit Experiment by parameters page.

new Trial Template Params

/assign @gaocegege @johnugeorge

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

2 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@aws-kf-ci-bot
Copy link
Contributor

aws-kf-ci-bot commented Oct 22, 2020

@andreyvelich: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
presubmit-katib-e2e 8cafb83 link /test presubmit-katib-e2e
kubeflow-katib-presubmit 8cafb83 link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andreyvelich andreyvelich force-pushed the issue-1217-ui-param-submit-trial-template branch from 8cafb83 to 67a4edb Compare October 26, 2020 22:03
@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f75f9fe into kubeflow:master Oct 27, 2020
@andreyvelich andreyvelich deleted the issue-1217-ui-param-submit-trial-template branch October 3, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Support new Trial template in Katib UI
6 participants