Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Early Stopped Trials in Goptuna Suggestion #1404

Merged

Conversation

andreyvelich
Copy link
Member

In Goptuna Suggestion we should transfer the EarlyStopped Trials to Pruned.
Is that correct @c-bata ?

Also, I added additional info in errors.

/assign @c-bata @gaocegege @johnugeorge

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 88204e3 into kubeflow:master Dec 1, 2020
@c-bata
Copy link
Member

c-bata commented Dec 1, 2020

In Goptuna Suggestion we should transfer the EarlyStopped Trials to Pruned.
Is that correct @c-bata ?

Correct 👍 Thanks!


This is just a nit-picking comment but it is recommended to not capitalize the error string by Golang wiki.

Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

@andreyvelich
Copy link
Member Author

This is just a nit-picking comment but it is recommended to not capitalize the error string by Golang wiki.

Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Got it, thank you for this info.
Sorry for these changes.

@andreyvelich andreyvelich deleted the goptuna-fix-earlystopped-trials branch October 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants