Add SVG logo traced from bitmap logo #1414
Conversation
| @@ -0,0 +1,17 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="762" width="548"> | |||
There was a problem hiding this comment.
Should we use your new logo instead of https://github.com/kubeflow/katib/blob/master/docs/images/Katib_Logo.png to be consistent ?
WDYT @gaocegege @johnugeorge ?
|
/retest |
|
/test kubeflow-katib-presubmit |
|
I updated the PNG logo as well. I switched to the Urbanist font vs Calibri, as Calibri is not licensed for use on non-Windows machines. I chose Urbanist after looking around for fonts that had the same clean, straight design, but can switch it to another font if desired. |
| @@ -0,0 +1,17 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="762" width="548"> | |||
There was a problem hiding this comment.
I think you should update the README link as well: https://github.com/kubeflow/katib/blame/master/README.md#L2.
There was a problem hiding this comment.
Updated that link, and also added pngs of both SVG files as logo.png and logo-title.png, to match the SVG filenames.
For future reference, making the pngs was pretty easy, if they ever get edited again:
cd docs/images/
inkscape logo.svg -o logo.png
inkscape logo-title.svg -o logo-title.png
|
/lgtm Thanks for your contribution! 🎉 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, knkski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds SVG logo traced from bitmap logo, for use in contexts that require vector graphics. Includes both just logo, and logo with "Katib" title below it. Also symlinks
icon.svgto the new logo file for each charm.