-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change roles to clusterroles for operators #1426
Change roles to clusterroles for operators #1426
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @DomFleischmann. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @DomFleischmann!
/ok-to-test
@DomFleischmann this looks good to me. cc @andreyvelich, @DomFleischmann has recently joined the team as another colleague for Kubeflow ventures. As he has plenty of operator experience, I think it's great to have him as an approver here. I'm happy to remove myself if you think we should stick to 2 people as @knkski and @DomFleischmann work with this code more on a daily basis. /lgtm |
/hold |
It's great, thank you @RFMVasconcelos and @DomFleischmann !
It's fine to have more than 2 people in the approval list, so we can leave it as it is. |
This will change the katib-controller and katib-ui roles to clusterroles. Additionally Dominik Fleischmann is being added to the owners of the katib operators.
3fc12f3
to
66d3aa7
Compare
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DomFleischmann, RFMVasconcelos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/verify-owners |
1 similar comment
/verify-owners |
@Bobgy @terrytangyuan Do you know why we still can't add @DomFleischmann to the OWNERS file ? |
@DomFleischmann needs to accept an invitation from kubeflow org first. |
Just joined, thank you! |
/verify-owners |
Thank you @andreyvelich and @Bobgy ! |
This will change the katib-controller and katib-uiroles to clusterroles.
Additionally Dominik Fleischmann is being added to the owners of the katib operators.