Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change roles to clusterroles for operators #1426

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

DomFleischmann
Copy link
Contributor

This will change the katib-controller and katib-uiroles to clusterroles.

Additionally Dominik Fleischmann is being added to the owners of the katib operators.

@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aws-kf-ci-bot
Copy link
Contributor

Hi @DomFleischmann. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DomFleischmann
Copy link
Contributor Author

DomFleischmann commented Feb 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

memo Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).

information_source Googlers: Go here for more info.

@googlebot I signed it!

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @DomFleischmann!
/ok-to-test

operators/OWNERS Outdated Show resolved Hide resolved
@rui-vas
Copy link
Contributor

rui-vas commented Feb 8, 2021

@DomFleischmann this looks good to me.

cc @andreyvelich, @DomFleischmann has recently joined the team as another colleague for Kubeflow ventures. As he has plenty of operator experience, I think it's great to have him as an approver here.

I'm happy to remove myself if you think we should stick to 2 people as @knkski and @DomFleischmann work with this code more on a daily basis.

/lgtm
/approve

@rui-vas
Copy link
Contributor

rui-vas commented Feb 8, 2021

/hold

@andreyvelich
Copy link
Member

It's great, thank you @RFMVasconcelos and @DomFleischmann !

I'm happy to remove myself if you think we should stick to 2 people as @knkski and @DomFleischmann work with this code more on a daily basis.

It's fine to have more than 2 people in the approval list, so we can leave it as it is.

This will change the katib-controller and katib-ui
roles to clusterroles.

Additionally Dominik Fleischmann is being added to
the owners of the katib operators.
@rui-vas
Copy link
Contributor

rui-vas commented Feb 8, 2021

/unhold
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DomFleischmann, RFMVasconcelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/verify-owners

1 similar comment
@andreyvelich
Copy link
Member

/verify-owners

@andreyvelich
Copy link
Member

@Bobgy @terrytangyuan Do you know why we still can't add @DomFleischmann to the OWNERS file ?
kubeflow/internal-acls#431 PR was merged.

@Bobgy
Copy link

Bobgy commented Feb 9, 2021

@DomFleischmann needs to accept an invitation from kubeflow org first.

@DomFleischmann
Copy link
Contributor Author

@DomFleischmann needs to accept an invitation from kubeflow org first.

Just joined, thank you!

@andreyvelich
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot merged commit 5e6a4ba into kubeflow:master Feb 9, 2021
@rui-vas
Copy link
Contributor

rui-vas commented Feb 9, 2021

Thank you @andreyvelich and @Bobgy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants