-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trial images build to the CI #1457
Add Trial images build to the CI #1457
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rename example folder for PyTorch mnist
Fix problems with current image build
9185310
to
a2a58ff
Compare
@gaocegege @johnugeorge I think the tests are working fine, can you take a look please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Blocked by: kubeflow/testing#923.
I added build of Katib Trial template images to the CI to make sure that each Trial template example can be built and executed.
As well, I fixed few problems with the current images:
--log-path
flag to PyTorch mnist to use this example inFile
andStdOut
metrics collector mode.docker.io/kubeflowkatib/pytorch-mnist
instead ofgcr.io/kubeflow-ci/pytorch-dist-mnist-test:v1.0
since it is similar images.mxnet/python:latest_cpu_native_py3
base image in MXNet since it has all required MXNet setup.tensorflow/tensorflow:1.15.4-py3
andtensorflow/tensorflow:1.15.4-gpu-py3
for ENAS CNN Trial template. With that setup we can have only 1 requirements.txt for this image and we can cut the Dockerfile.After we merge this PR, I will execute release script to push new images to the
kubeflowkatib
registry. Then I will update tags for the Katib Trial templates./assign @gaocegege @johnugeorge
/cc @PatrickXYS