Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release process script #1473

Merged
merged 6 commits into from
Mar 17, 2021

Conversation

andreyvelich
Copy link
Member

Fixes: #1466.

I added Katib release script.
In Makefile we currently have:

  1. push-latest to publish images to the registry with the latest and commit tags from the master branch.
  2. push-tag to publish image to the registry with the release and commit tags from the release branch.
  3. release to make a new Katib release.

I changed build.sh and push.sh scripts to use them when publishing latest images and release images.

Release script follows this (e.g. Branch = release-0.11, Tag = v0.11.0):

  1. Clone Katib repo to the temp dir.
  2. Create a new branch (release-0.11), if it doesn't exist or use the existing branch.
  3. Change image tags to the v0.11.0 in the Katib installs.
  4. Publish Katib SDK with version - 0.11.0.
  5. Commit changes in the release-0.11 branch and add v0.11.0 tag to this commit.
  6. Publish Katib images with 2 tags: v1beta1-<commit-SHA> and v0.11.0.
  7. Push release-0.11 branch and v0.11.0 tag to the upstream.

Please take a look.
/assign @yanniszark @gaocegege @johnugeorge

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/hold for the review

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

After discussion with @yanniszark, we decided to leave only one tag in Push and Build scripts and run them for the release tag and commit tag.

@yanniszark
Copy link
Contributor

Thanks @andreyvelich!
/lgtm

@johnugeorge
Copy link
Member

/lgtm

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@andreyvelich
Copy link
Member Author

Thanks for the review!
/hold cancel

@andreyvelich
Copy link
Member Author

/retest

@google-oss-robot google-oss-robot merged commit 3935da8 into kubeflow:master Mar 17, 2021
@andreyvelich andreyvelich deleted the add-release-process branch October 6, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Katib release process
5 participants