-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifests for the new UI #1476
Manifests for the new UI #1476
Conversation
I see that the Argo workflow for the presubmit tests fail in the task
I'll try to rerun the tests in case this was ephemeral |
@kimwnasptd Thank you for doing this. |
Yes, that would be great. We can say how user should modify |
@@ -0,0 +1,38 @@ | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you check the latest manifest for the UI: https://github.com/kubeflow/katib/tree/master/manifests/v1beta1/components/ui.
We've made few changes to to the labels and imagePullPolicy
@andreyvelich as we briefly discussed since these manifests are identical with the one for the current UI instead of copy pasting the almost same manifests I'll edit the README of the repo to instruct users on how to use the new UI. I'll use this PR for this, but I'll force push the changes instead |
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
ede0c2c
to
e08e969
Compare
Force pushed the new small section in the README, @andreyvelich @gaocegege @johnugeorge looking forward to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update @kimwnasptd.
I added comments.
Adds a top level table-of-contents entry for the new UI as well. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
24a9839
to
06303c3
Compare
Overall text looks good, thank you @kimwnasptd. |
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution! 🎉 👍
Let's merge this. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds manifests for the new UI #1421 we've been working on in 1.3. These manifests are aimed to make it easier for people to try out this UI and give us some feedback. The default UI will be the current one.
Which issue(s) this PR fixes:
First step for #1469 and #1474
Special notes for your reviewer:
katib-new-ui
names for these yamls instead, but this might complicate things because we will need to create anotherVirtualService
for ISTIOdocker.io/kubeflowkatib/katib-new-ui
Just some questions I had:
README.md
in thenew-ui
folder to iterate again that this UI is not yet on par with the current one?manifests/v1beta1/components
andmanifests/v1beta1
folders?/cc @andreyvelich @gaocegege @johnugeorge