-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default image for the new Katib UI #1608
Change the default image for the new Katib UI #1608
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We should decide which image we are going to use for the new Katib UI. /hold |
docker.io/kubeflowkatib/katib-ui SGTM |
SGTM |
I am using /hold cancel |
/retest |
Tests are passed, @kimwnasptd @gaocegege @johnugeorge if you are fine with the changes let's merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Related: #1597.
As we discussed, for Kubeflow 1.4 in the default Katib manifests we will use the new Katib UI image.
We still need to make some changes in the website docs: #1595 before the release.
I modified Katib README, please take a look.
/assign @kimwnasptd @gaocegege @johnugeorge
/hold for the review.