Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metrics Collector error in case of non-existing Process #1614

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Fix Metrics Collector error in case of non-existing Process #1614

merged 4 commits into from
Aug 12, 2021

Conversation

andreyvelich
Copy link
Member

Fixes: #1576.

This fix should help with the non-existing process error.
I noticed that other steps (proc.Ppid() and proc.Cmdline()) can also be failed.
I skipped error for them as well.

/cc @gaocegege @chenwenjun-github @johnugeorge

@google-oss-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: chenwenjun-github.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1576.

This fix should help with the non-existing process error.
I noticed that other steps (proc.Ppid() and proc.Cmdline()) can also be failed.
I skipped error for them as well.

/cc @gaocegege @chenwenjun-github @johnugeorge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gaocegege
gaocegege reviewed Aug 12, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

/retest

5 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@google-oss-robot google-oss-robot merged commit abbc9c9 into kubeflow:master Aug 12, 2021
@andreyvelich andreyvelich deleted the issue-1576-fix-empty-process branch August 26, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdout metric collector failed
3 participants
@andreyvelich @google-oss-robot @gaocegege