-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor README #1667
Refactor README #1667
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table looks nice :)
README.md
Outdated
Learn more about various Katib installs in the | ||
[Kubeflow guide](https://www.kubeflow.org/docs/components/katib/hyperparameter/#katib-setup). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving this sentence to right after #Installation
, and add explanation following Installation is for stand-alone or for quick-start ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point, thanks @anencore94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the supported K8s version to this documentation.
It might be better to use the kustomize
binary instead of the built-in kustomize
, since the kustomize
version used by each user may be very different, and the built-in kustomize does not immediately bug fixes.
What do you think @andreyvelich ?
For the specific Katib release (for example `v0.11.1`) run this command: | ||
|
||
``` | ||
kubectl apply -k "github.com/kubeflow/katib.git/manifests/v1beta1/installs/katib-standalone?ref=v0.11.1" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
For the latest Katib version run this command: | ||
|
||
``` | ||
kubectl apply -k "github.com/kubeflow/katib.git/manifests/v1beta1/installs/katib-standalone?ref=master" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
||
- Kubernetes >= 1.17 | ||
- `kubectl` >= 1.21 | ||
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Thank you for the review @tenzen-y.
Before the installation we have the requirements that user should install That will remove additional step for the new users to install For most advance users they can always follow the Kubeflow Katib guide to manipulate WDYT @tenzen-y @gaocegege @johnugeorge ? |
It sounds good. I was relieved to see that the detailed installation instructions are still available. |
README.md
Outdated
|
||
Katib supports Python SDK: | ||
- TODO (andreyvelich): Add Katib components section from the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this till we add this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, does it look good to you: https://github.com/kubeflow/katib/blob/e2434e3c3c4001280d8ca1eb9d0af74fd17aed75/README.md#documentation ?
I made the similar sentences.
One thing that we have to add is , Why Katib is a better choice ? We can take this up later |
Sure, I created issue to track this. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
/lgtm |
/hold cancel |
Fixes: #1570.
I made some changes in the README to leave only necessary information for our users.
Few questions:
implementation
in the Algorithm table with type of framework that we use (e.g.hyperopt
,optuna
,goptuna
) ?Why Katib ?
) ?Please take a look and give your feedback @gaocegege @johnugeorge @kimwnasptd @jbottum @RFMVasconcelos @anencore94 @tenzen-y @c-bata @g-votte