-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add envtest to check reconcileRBAC
#1678
Add envtest to check reconcileRBAC
#1678
Conversation
Hi @tenzen-y. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/cc @andreyvelich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this @tenzen-y!
It's useful.
pkg/controller.v1beta1/suggestion/suggestion_controller_test.go
Outdated
Show resolved
Hide resolved
/ok-to-test |
7a0da15
to
11d6599
Compare
11d6599
to
2b6be1a
Compare
182ee52
to
b6e2269
Compare
af2b772
to
0ca9bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates @tenzen-y!
/lgtm
/assign @gaocegege @johnugeorge
pkg/controller.v1beta1/suggestion/suggestion_controller_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution! 🎉 👍
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, there are not any tests to check the
reconcileRBAC
in the following coverage reports. So, I think it might be better to add tests to check it.