Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FPGA examples #1685

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Update FPGA examples #1685

merged 4 commits into from
Sep 29, 2021

Conversation

eliaskoromilas
Copy link
Member

What this PR does / why we need it:

  • Update the FPGA XGBoost experiment:

  • Update AWS F1 instructions:

    • from InAccel EKS-optimized FPGA AMI to InAccel FPGA Operator

@aws-kf-ci-bot
Copy link
Contributor

Hi @eliaskoromilas. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the FPGA example @eliaskoromilas!
/ok-to-test

What do you think about adding OWNERS file under examples/v1beta1/fpga ?
Then, users will know whom to ask their questions.

/assign @gaocegege @johnugeorge

@eliaskoromilas
Copy link
Member Author

We plan to add more FPGA experiments.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

/lgtm

Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
@johnugeorge
Copy link
Member

I think, one cannot be a owner without being a Kubeflow member. We might need to skip owner file change for now

/lgtm

@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

I think, one cannot be a owner without being a Kubeflow member. We might need to skip owner file change for now

I think we can just keep it to let users know who they can ask for help when they have problems with FPGA example.

@andreyvelich
Copy link
Member

We can add them to the Kubeflow org, what do you think @gaocegege @johnugeorge ?

@gaocegege
Copy link
Member

I have no objection to it.

@eliaskoromilas
Copy link
Member Author

rebase

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member

/verify-owners

@eliaskoromilas
Copy link
Member Author

/verify-owners

@andreyvelich
Copy link
Member

Thank you for driving this!
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, eliaskoromilas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 40a2fc8 into kubeflow:master Sep 29, 2021
@eliaskoromilas eliaskoromilas deleted the fpga-examples branch October 19, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants