-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FPGA examples #1685
Update FPGA examples #1685
Conversation
Hi @eliaskoromilas. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the FPGA example @eliaskoromilas!
/ok-to-test
What do you think about adding OWNERS file under examples/v1beta1/fpga
?
Then, users will know whom to ask their questions.
/assign @gaocegege @johnugeorge
We plan to add more FPGA experiments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! 🎉 👍
/lgtm |
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
I think, one cannot be a owner without being a Kubeflow member. We might need to skip owner file change for now /lgtm |
/retest |
I think we can just keep it to let users know who they can ask for help when they have problems with FPGA example. |
We can add them to the Kubeflow org, what do you think @gaocegege @johnugeorge ? |
I have no objection to it. |
rebase |
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
/verify-owners |
/verify-owners |
Thank you for driving this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, eliaskoromilas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Update the FPGA XGBoost experiment:
Update AWS F1 instructions: